Skip to content

Commit

Permalink
ci: update workflow dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
cilki committed May 19, 2024
1 parent c57000a commit 2ce2374
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 62 deletions.
20 changes: 1 addition & 19 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: nightly / doc
steps:
- run: sudo apt-get install -y libpango1.0-dev
- run: sudo apt-get install -y libpango1.0-dev libgraphene-1.0-dev
- uses: actions/checkout@v4
with:
submodules: true
Expand All @@ -79,24 +79,6 @@ jobs:
run: cargo doc --no-deps --all-features
env:
RUSTDOCFLAGS: --cfg docsrs
hack:
# cargo-hack checks combinations of feature flags to ensure that features are all additive
# which is required for feature unification
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: ubuntu / stable / features
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install stable
uses: dtolnay/rust-toolchain@stable
- name: cargo install cargo-hack
uses: taiki-e/install-action@cargo-hack
# intentionally no target specifier; see https://github.com/jonhoo/rust-ci-conf/pull/4
# --feature-powerset runs for every combination of features
- name: cargo hack
run: cargo hack --feature-powerset check
msrv:
# check that we can build using the minimal rust version that is specified by this crate
runs-on: ubuntu-latest
Expand Down
45 changes: 2 additions & 43 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
# toolchain
toolchain: [stable, beta]
steps:
- run: sudo apt-get install -y libpango1.0-dev
- run: sudo apt-get install -y libpango1.0-dev libgraphene-1.0-dev libudev-dev libgtk-4-dev libglib2.0-dev
- uses: actions/checkout@v4
with:
submodules: true
Expand All @@ -45,47 +45,6 @@ jobs:
# https://github.com/rust-lang/cargo/issues/6669
- name: cargo test --doc
run: cargo test --locked --all-features --doc
minimal:
# This action chooses the oldest version of the dependencies permitted by Cargo.toml to ensure
# that this crate is compatible with the minimal version that this crate and its dependencies
# require. This will pickup issues where this create relies on functionality that was introduced
# later than the actual version specified (e.g., when we choose just a major version, but a
# method was added after this version).
#
# This particular check can be difficult to get to succeed as often transitive dependencies may
# be incorrectly specified (e.g., a dependency specifies 1.0 but really requires 1.1.5). There
# is an alternative flag available -Zdirect-minimal-versions that uses the minimal versions for
# direct dependencies of this crate, while selecting the maximal versions for the transitive
# dependencies. Alternatively, you can add a line in your Cargo.toml to artificially increase
# the minimal dependency, which you do with e.g.:
# ```toml
# # for minimal-versions
# [target.'cfg(any())'.dependencies]
# openssl = { version = "0.10.55", optional = true } # needed to allow foo to build with -Zminimal-versions
# ```
# The optional = true is necessary in case that dependency isn't otherwise transitively required
# by your library, and the target bit is so that this dependency edge never actually affects
# Cargo build order. See also
# https://github.com/jonhoo/fantoccini/blob/fde336472b712bc7ebf5b4e772023a7ba71b2262/Cargo.toml#L47-L49.
# This action is run on ubuntu with the stable toolchain, as it is not expected to fail
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: ubuntu / stable / minimal-versions
steps:
- run: sudo apt-get install -y libpango1.0-dev
- uses: actions/checkout@v4
with:
submodules: true
- name: Install stable
uses: dtolnay/rust-toolchain@stable
- name: Install nightly for -Zminimal-versions
uses: dtolnay/rust-toolchain@nightly
- name: rustup default stable
run: rustup default stable
- name: cargo update -Zminimal-versions
run: cargo +nightly update -Zminimal-versions
- name: cargo test
run: cargo test --locked --all-features --all-targets
os-check:
# run cargo test on mac and windows
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -138,7 +97,7 @@ jobs:
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: ubuntu / stable / coverage
steps:
- run: sudo apt-get install -y libpango1.0-dev
- run: sudo apt-get install -y libpango1.0-dev libgraphene-1.0-dev libudev-dev libgtk-4-dev libglib2.0-dev
- uses: actions/checkout@v4
with:
submodules: true
Expand Down

0 comments on commit 2ce2374

Please sign in to comment.