Update foundation_and_overrides template to add missing foundation components (6.4.1) #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm this is a sorely needed merge. Built a page using "foundation new" (zurb template) and then afterwards I transferred it over to a rails app with foundation-rails gem and saw the design was broken. Applying the fix from @patricklindsay solved it. |
This was referenced Oct 21, 2017
|
@kball Could we please pull in this change? |
|
merged, tagged, and pushed to rubygems. Sorry about the slow response - I'm out of ZURB now and have been racing around trying to get my own business up to speed |
|
@kball no worries! Is there a new contact we should use for this gem? |
ncoden
added a commit
to ncoden/foundation-rails
that referenced
this pull request
Mar 13, 2018
### Major changes: * Upgrade to Foundation `v6.4.3` (foundation#254, @chrisfinne) * Add Autoprefixer (foundation#255, @bassjobsen) ### Bug fixes: * Fix issue with smoothScroll import order (foundation#236 @MicahBrown) * Add missing SCSS components to template (foundation#237 @patricklindsay) * Prevent Sass depreciation (foundation#252, @michsch) ### Cleaning: * Remove old Foundation files (foundation#251 @jessedoyle) ### See also: * Foundation 6.4.3 release notes: https://github.com/zurb/foundation-sites/releases/tag/v6.4.3 * Foundation 6.4.2 release notes: https://github.com/zurb/foundation-sites/releases/tag/v6.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
As stated in that issue the current template does not include the full list of current Foundation components, including the most recently added XY grid functionality.
I copied the component list from Foundation SASS docs.