Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

yarn serve doesn't watch all files #893

Closed
jtbandes opened this issue May 7, 2021 · 4 comments
Closed

yarn serve doesn't watch all files #893

jtbandes opened this issue May 7, 2021 · 4 comments
Labels
devx Relates to developers working in the studio repo

Comments

@jtbandes
Copy link
Member

jtbandes commented May 7, 2021

Steps to reproduce:

  • Run yarn serve on main.
  • Edit the PanelConfigSchemaEntry type in app/types/panels.ts, or edit the RegisteredIconNames type in app/typings/fluentui.d.ts.

Webpack does not even attempt to rebuild any files when these two files are changed.

It seems likely that this is a regression caused by #829 / #839.
@jtbandes jtbandes added the bug The user is unable to complete a supported task, or the software does not behave as intended label May 7, 2021
@jtbandes
Copy link
Member Author

jtbandes commented May 11, 2021 •
edited
Loading

I created a minimal partial repro (though the studio repo still has issues even when applying the workaround) and filed an issue against fork-ts-checker: TypeStrong/fork-ts-checker-webpack-plugin#611

@jtbandes jtbandes mentioned this issue May 11, 2021
Open
@defunctzombie
Copy link
Contributor

@jtbandes I propose removing the bug label from this issue - maybe a different label? I'd like to keep bug as an indicator for user-facing/product bugs.

@jtbandes jtbandes added devx Relates to developers working in the studio repo and removed bug The user is unable to complete a supported task, or the software does not behave as intended labels May 14, 2021
@jtbandes jtbandes self-assigned this May 14, 2021
@jtbandes jtbandes mentioned this issue May 15, 2021
Closed
@jtbandes jtbandes removed their assignment Sep 14, 2021
@github-actions
Copy link

This issue has been marked as stale because there has been no activity in the past 6 months. Please add a comment to keep it open.

@github-actions github-actions bot added the stale label Mar 14, 2022
@jtbandes jtbandes removed the stale label Mar 14, 2022
@jtbandes
Copy link
Member Author

jtbandes commented Sep 8, 2022

Seems like this has improved.

@jtbandes jtbandes closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
devx Relates to developers working in the studio repo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workaround for webpack --watch / fork-ts-checker issues foxglove/studio
2 participants
@jtbandes @defunctzombie