This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Workaround for webpack --watch / fork-ts-checker issues
#967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
force-pushed
the
jacob/tsconfig-paths-and-includes
branch
2 times, most recently
from
df6f29c
to
bf1887a
Compare
There is an issue with fork-ts-checker (or perhaps we are misusing it) such that it does not re-typecheck the correct files when a change is made in the app, most notably for files that only export types. (TypeStrong/fork-ts-checker-webpack-plugin#611) This change forces it to look at these files in our package source directories rather than the symlinks in node_modules created by yarn workspaces. Now they are correctly watched and new type errors show up when a type-only file is edited. fix build error fix yarn.lock Move base tsconfig changes to desktop tsconfigs
jtbandes
force-pushed
the
jacob/tsconfig-paths-and-includes
branch
from
bf1887a
to
3c442db
Compare
jtbandes
force-pushed
the
jacob/tsconfig-paths-and-includes
branch
from
77ada42
to
50d3872
Compare
|
|
||
| // These includes are added to ensure that fork-ts-checker correctly typechecks changed files: | ||
| // https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/611 | ||
| "../../app/**/*", |
There was a problem hiding this comment.
We should wait on this until we move app into packages
|
@jtbandes still doing anything with this? Was it ever resolved upstream? |
|
I don't think it was resolved upstream – we still experience issues with webpack not updating when types are changed. We've all just become used to restarting the dev server occasionally. I'm not sure this approach is desired so I'll close the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround forces fork-ts-checker to watch file dependencies in our packages dirs. Previously it would not rebuild when certain types-only files were changed (TypeStrong/fork-ts-checker-webpack-plugin#611).
Fixes #893