Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[franka_hw] Install plugin xml to enable to load FrankaCombinableHW from apt version of franka_hw #298

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pazeshun
Copy link

When I try to load franka_hw/FrankaCombinableHW from apt version of franka_hw, I faced the following error:

[ERROR] [/dual_panda] [1668147868.535937528]: Skipped loading plugin with error: XML Document '/opt/ros/melodic/share/franka_hw/franka_combinable_hw_plugin.xml' has no Root Element. This likely means the XML is malformed or missing..
[ERROR] [/dual_panda] [1668147868.537817487]: Could not load robot HW 'rarm' because robot HW type 'franka_hw/FrankaCombinableHW' does not exist.
[ERROR] [/dual_panda] [1668147868.555089521]: franka_combined_control_node:: Initialization of FrankaCombinedHW failed!

This is because franka_hw/franka_combinable_hw_plugin.xml is not installed:

## Installation
install(TARGETS franka_hw franka_control_services
ARCHIVE DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}
LIBRARY DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}
RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}
)
install(DIRECTORY include/${PROJECT_NAME}/
DESTINATION ${CATKIN_PACKAGE_INCLUDE_DESTINATION}
)

This PR installs franka_hw/franka_combinable_hw_plugin.xml.
I confirmed this PR works by:

catkin init
catkin config --install
catkin build
source <WORKSPACE_PATH>/install/setup.bash

cf. https://answers.ros.org/question/274849/gmapping-skipping-xml-document/

pazeshun added a commit to pazeshun/jsk_robot that referenced this pull request Nov 11, 2022
pazeshun added a commit to pazeshun/jsk_robot that referenced this pull request Nov 11, 2022
pazeshun added a commit to pazeshun/jsk_robot that referenced this pull request Nov 11, 2022
pazeshun added a commit to pazeshun/jsk_robot that referenced this pull request Nov 11, 2022
pazeshun added a commit to pazeshun/jsk_robot that referenced this pull request Nov 19, 2022
@rickstaa
Copy link
Contributor

rickstaa commented Sep 4, 2023

@pazeshun, thanks for your pull request. It fixes a trivial issue 👍🏻. I tested it using the franka_combined_control.launch file, and it works. I hope @frankaemika will merge it soon 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants