Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order of types #11

Merged
merged 1 commit into from
Feb 13, 2022
Merged

fix: order of types #11

merged 1 commit into from
Feb 13, 2022

Conversation

ShuguangSun
Copy link
Contributor

Try to fix issue #10

Loop through the types as ordered by the useer.

@friendly
Copy link
Owner

Thanks for this. I'll check it out.

@friendly friendly merged commit bc30b23 into friendly:master Feb 13, 2022
@friendly
Copy link
Owner

This PR fixes problems 1 & 3 reported by @mattkumar, but it does not fix problem 2. In particular:

## Test 2 - types = "rmeans" [Not OK]
# In this test case, the `row means` test statistic is of particular interest and specify it directly.

CMHtest(Freq~x+y|k, data=r_cmh, overall=TRUE, details=TRUE, types = "rmeans")$ALL$table

# The df and p-value are still returned as NA.

# Chisq    Df Prob
# rmeans 26.02779 NA NA  

I've merged it anyway for now. This case should be investigated further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants