Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding [email protected] #98

Merged
merged 3 commits into from
Jan 26, 2020
Merged

Adding [email protected] #98

merged 3 commits into from
Jan 26, 2020

Conversation

almahmoud
Copy link
Member

@almahmoud almahmoud commented Jan 16, 2020

Adding [email protected]+galaxy1
Adding [email protected]

@almahmoud almahmoud requested a review from a team as a code owner January 16, 2020 01:39
@natefoo
Copy link
Member

natefoo commented Jan 16, 2020

@galaxybot test this

@natefoo
Copy link
Member

natefoo commented Jan 16, 2020

Could you add this just to the usegalaxy.org toolset for now? We're not using the common toolset yet.

@almahmoud almahmoud requested a review from a team as a code owner January 21, 2020 17:49
@almahmoud
Copy link
Member Author

Done! Sorry for the delay

@natefoo
Copy link
Member

natefoo commented Jan 21, 2020

This won't work until bioconda/bioconda-recipes#19790 is fixed, will it?

@bgruening
Copy link
Member

@almahmoud I created already a fixed container. And to fix your tool on usegalaxy.org, copy the binary manually into your conda dir ...

@natefoo
Copy link
Member

natefoo commented Jan 21, 2020

Copy from the biocontainer? Or is the binary available somewhere else?

@almahmoud
Copy link
Member Author

almahmoud commented Jan 21, 2020

@bgruening Are you referring to: quay.io/biocontainers/prokka:1.14.5--pl526_0? And would it be possible to patch this in: tseemann/prokka#451 to work with NFS?

@bgruening
Copy link
Member

wget ftp://ftp.ncbi.nih.gov/toolbox/ncbi_tools/converters/by_program/tbl2asn/linux.tbl2asn.gz

@almahmoud, yes please test, this one should work hopefully.

@almahmoud
Copy link
Member Author

almahmoud commented Jan 21, 2020

Unfortunately, quay.io/biocontainers/prokka:1.14.5--pl526_0 does not work :/ (says it has old tbl2asn)
Update: I didn't realize the updated container was re-using an existing tag, and that image was already pulled on the machine. After deleting and re-pulling the old one, tbl2asn works, just need to add the patch tseemann/prokka#451 to work on NFS, otherwise the container works in other scnearios.

@bgruening
Copy link
Member

bag@bag:~/projects/code/galaxytools/tools/rna_tools/graphprot$ docker run quay.io/biocontainers/prokka:1.14.5--pl526_0 tbl2asn
[tbl2asn] You must supply either an input file (-i) or an input directory (-p).
Use -p . to specify the current directory.

Seems to work for me.

@almahmoud
Copy link
Member Author

I added just the newest (working) one for now to get a working prokka on Main in the meantime, until we add and patch the other one(s) as well.

@almahmoud almahmoud changed the title Prokka update Adding [email protected] Jan 24, 2020
@natefoo
Copy link
Member

natefoo commented Jan 24, 2020

@galaxybot test this

@natefoo
Copy link
Member

natefoo commented Jan 26, 2020

@galaxybot deploy this

@natefoo natefoo merged commit 69ee478 into galaxyproject:master Jan 26, 2020
@natefoo
Copy link
Member

natefoo commented Jan 27, 2020

I also snuck tbl2asn updates in to the prokka 1.12 and 1.13 conda envs during this install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants