Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BoundingBox Msg #165

Merged
merged 5 commits into from
Aug 18, 2021
Merged

Add BoundingBox Msg #165

merged 5 commits into from
Aug 18, 2021

Conversation

AmrElsersy
Copy link
Contributor

@AmrElsersy AmrElsersy commented Jun 16, 2021

🎉 New feature

Summary

Related to gazebosim/gz-sensors#135

Add BoundingBox Msg & BoundingBoxes Msg to be used in the BoundingBoxCameraSensor in PR #136

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: AmrElsersy <[email protected]>
@AmrElsersy AmrElsersy requested a review from caguero as a code owner June 16, 2021 20:04
@osrf-triage osrf-triage added this to Inbox in Core development Jun 16, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 16, 2021
@adlarkin adlarkin self-requested a review June 16, 2021 20:53
proto/ignition/msgs/bounding_box.proto Outdated Show resolved Hide resolved
proto/ignition/msgs/bounding_box.proto Outdated Show resolved Hide resolved
proto/ignition/msgs/bounding_box.proto Outdated Show resolved Hide resolved
proto/ignition/msgs/bounding_boxes.proto Outdated Show resolved Hide resolved
@chapulina chapulina moved this from Inbox to In review in Core development Jun 17, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #165 (d09686d) into main (d21be7a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files           7        7           
  Lines         828      828           
=======================================
  Hits          702      702           
  Misses        126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21be7a...d09686d. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The general structure LGTM, the main thing to fix before merging is the typo.

proto/ignition/msgs/annotated_oreinted_3d_box.proto Outdated Show resolved Hide resolved
proto/ignition/msgs/oreinted_3d_box.proto Outdated Show resolved Hide resolved
Signed-off-by: AmrElsersy <[email protected]>
proto/ignition/msgs/annotated_axis_aligned_2d_box.proto Outdated Show resolved Hide resolved
proto/ignition/msgs/annotated_axis_aligned_2d_box_v.proto Outdated Show resolved Hide resolved
proto/ignition/msgs/annotated_oriented_3d_box.proto Outdated Show resolved Hide resolved
proto/ignition/msgs/annotated_oriented_3d_box_v.proto Outdated Show resolved Hide resolved
proto/ignition/msgs/axis_aligned_2d_box.proto Outdated Show resolved Hide resolved
proto/ignition/msgs/oriented_3d_box.proto Outdated Show resolved Hide resolved
proto/ignition/msgs/oriented_3d_box.proto Outdated Show resolved Hide resolved
Signed-off-by: AmrElsersy <[email protected]>
@AmrElsersy AmrElsersy requested a review from adlarkin July 23, 2021 11:44
@adlarkin adlarkin merged commit 57d13bb into gazebosim:main Aug 18, 2021
Core development automation moved this from In review to Done Aug 18, 2021
@chapulina chapulina moved this from Done to Highlights in Core development Aug 18, 2021
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/gsoc-2021-machine-learning-extension-to-ignition-gazebo/1070/1

@j-rivero j-rivero removed this from Highlights in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants