Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using gz_frame_id emits a warning; should be part of the SDFormat spec #306

Open
azeey opened this issue Jan 6, 2023 · 6 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@azeey
Copy link
Contributor

azeey commented Jan 6, 2023

Environment

  • OS Version: any
  • Source or binary build? any

Description

  • Expected behavior: No warnings when using gz_frame_id to set a custom frame id for a sensor in gz-sim.
  • Actual behavior: The following error is emitted warning that the element gz_frame_id is not part of the SDFormat spec.
Warning [Utils.cc:130] [/sdf/world[@name="imu_sensor"]/model[@name="imu_model"]/link[@name="link"]/sensor[@name="imu_sensor"]/gz_frame_id:/home/addisu/ws/garden/src/gz-sim/test/worlds/imu.sdf:L75]: XML Element[gz_frame_id], child of element[sensor], not defined in SDF. Copying[gz_frame_id] as children of [sensor].

I think we'd want this tag in SDFormat. I would also say we could just use frame_id instead of gz_frame_id.

Steps to reproduce

  1. Modify gz-sim/test/worlds/imu.sdf to use gz_frame_id
  2. Run the world in gz sim.
@azeey azeey added the bug Something isn't working label Jan 6, 2023
@osrf-triage osrf-triage added this to Inbox in Core development Jan 6, 2023
@azeey azeey moved this from Inbox to To do in Core development Jan 9, 2023
@azeey
Copy link
Contributor Author

azeey commented Jan 9, 2023

There's also an optical_frame_id in SDFormat. Probably should consolidate all frame id info into the frame_id tag targeting Harmonic.

@azeey
Copy link
Contributor Author

azeey commented Aug 4, 2023

@ahcorde is this something we can do for Harmonic?

@muttistefano
Copy link

Hi all,
as of today is there a way to change the frame_id of a sensor?
I am using a gpu_lidar but I cannot manage to change the frame_id attached to the message.
Thanks

@azeey
Copy link
Contributor Author

azeey commented Apr 4, 2024

Hi all, as of today is there a way to change the frame_id of a sensor? I am using a gpu_lidar but I cannot manage to change the frame_id attached to the message. Thanks

Yes, you should be able to use gz_frame_id. In Fortress, you can use ign_frame_id (discouraged) or gz_frame_id.

@faizurrahman1998
Copy link

faizurrahman1998 commented Jun 30, 2024

Hello everyone,
I am facing the same problem. gz_frame_id tag is not changing the frame_id of the lidar_sensor. Rather, the lidar_sensor is publishing messages with frame_id of the format: ROBOT_NAME/base_footprint/NAME_OF_THE_SENSOR. is there any new fix for this?

Also, optical_frame_id is issuing the same warning.

@iche033
Copy link
Contributor

iche033 commented Jul 3, 2024

included frame id fix for lidar sensor in #444. I'll backport to gz-sensors8 (harmonic) and make it compatible with <gz_frame_id> once that PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

5 participants