Merge ign-sensors6 ➡️ gz-sensors7 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Louise Poubel <[email protected]>
* gpu_lidar DEPENDS_ON_COMPONENT lidar This is needed to fix ign-gazebo3 builds. * Add other missing DEPENDS_ON_COMPONENT Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
Signed-off-by: ahcorde <[email protected]> Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Brian Chen <[email protected]> * macOS testing: fix DYLD_LIBRARY_PATH * Test intrinsics and projection parameters Confirm that intrinsics and projection parameters in CameraInfo message match the values from SDFormat. Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Merge ign-sensors3 ➡️ ign-sensors6
scpeters
force-pushed
the
scpeters/merge_6_7
branch
from
5fa3351
to
fef9160
Compare
Codecov Report
@@ Coverage Diff @@
## gz-sensors7 #283 +/- ##
===============================================
+ Coverage 67.75% 69.17% +1.41%
===============================================
Files 35 35
Lines 3734 3740 +6
===============================================
+ Hits 2530 2587 +57
+ Misses 1204 1153 -51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
the rendering tests on windows are failing, not sure if that's expected or not |
|
oh just saw the issue: #284 |
I noticed the same, but they are already failing on |
iche033
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-sensors6➡️gz-sensors7Branch comparison: gz-sensors7...ign-sensors6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)