Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ogre tests on windows #303

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Dec 19, 2022

🦟 Bug fix

Toward #284

Summary

Ogre tests are not working on windows as discussed in #284.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

See gazebosim#284

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from iche033 as a code owner December 19, 2022 17:31
@osrf-triage osrf-triage added this to Inbox in Core development Dec 19, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #303 (80df6f8) into gz-sensors7 (fef9160) will increase coverage by 0.28%.
The diff coverage is 97.72%.

@@               Coverage Diff               @@
##           gz-sensors7     #303      +/-   ##
===============================================
+ Coverage        69.17%   69.45%   +0.28%     
===============================================
  Files               35       35              
  Lines             3740     3778      +38     
===============================================
+ Hits              2587     2624      +37     
- Misses            1153     1154       +1     
Impacted Files Coverage Δ
src/CameraSensor.cc 79.02% <97.22%> (+1.95%) ⬆️
src/NavSatSensor.cc 89.90% <100.00%> (ø)
src/Sensor.cc 91.44% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Core development automation moved this from Inbox to In review Dec 19, 2022
@azeey azeey merged commit 98c5eef into gazebosim:gz-sensors7 Dec 19, 2022
Core development automation moved this from In review to Done Dec 19, 2022
@azeey azeey deleted the disable_win_ogre branch December 19, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants