Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Automatic Moment of Inertia Calculations for Basic Shapes Pytho… #1424

Merged
merged 3 commits into from
May 30, 2024

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented May 28, 2024

🎉 New feature

Related with #1417 only for this PR https://github.com/gazebosim/sdformat/pull/1299/files

Summary

Added Automatic Moment of Inertia Calculations for Basic Shapes Python wrappers

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

…n wrapper

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
python/src/sdf/pyRoot.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor suggestion, otherwise looks good to me

Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde merged commit f9414e7 into sdf14 May 30, 2024
11 checks passed
@ahcorde ahcorde deleted the ahcorde/sdf14/autoinertial branch May 30, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants