Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment(replays): Use default JSON decoder #64079

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Jan 29, 2024

We're seeing a lot of "The surrogate pair in string is invalid" errors. This root cause seems to be rapidjson. The increase in errors might be attributable to our new canvas changes. Switching to the simplejson default decoder might allow us to parse these JSON messages.

Related to: Tencent/rapidjson#2259

@cmanallen cmanallen requested a review from a team as a code owner January 29, 2024 18:26
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (059538d) 81.25% compared to head (958f0dd) 81.24%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #64079      +/-   ##
==========================================
- Coverage   81.25%   81.24%   -0.01%     
==========================================
  Files        5228     5228              
  Lines      230501   230501              
  Branches    45238    45238              
==========================================
- Hits       187288   187275      -13     
- Misses      37365    37373       +8     
- Partials     5848     5853       +5     
Files Coverage Δ
src/sentry/replays/usecases/ingest/__init__.py 85.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@cmanallen cmanallen merged commit efa1b4b into master Jan 29, 2024
53 checks passed
@cmanallen cmanallen deleted the cmanallen/replays-drop-rapidjson branch January 29, 2024 18:53
Copy link

sentry-io bot commented Jan 30, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RecursionError: maximum recursion depth exceeded while decoding a JSON object from a unicode string sentry.utils.json in loads View Issue

Did you find this useful? React with a 👍 or 👎

snigdhas pushed a commit that referenced this pull request Jan 30, 2024
We're seeing a lot of "The surrogate pair in string is invalid" errors.
This root cause seems to be rapidjson. The increase in errors might be
attributable to our new canvas changes. Switching to the simplejson
default decoder might allow us to parse these JSON messages.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants