Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(ui): Upgrade to typescript 5.5 #73530

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Jun 28, 2024

some small fixes from .filter() on PlatformKey making a new type and .includes() then being mad that PlatformKey != the new type

https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/

some small fixes from .filter on PlatformKey making a new type and includes then getting mad that PlatformKey != the new type
@scttcper scttcper requested review from a team as code owners June 28, 2024 18:49
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.02%. Comparing base (fe8da9b) to head (e7f9196).

Current head e7f9196 differs from pull request most recent head 1c79632

Please upload reports for the commit 1c79632 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #73530       +/-   ##
===========================================
+ Coverage   47.74%   78.02%   +30.27%     
===========================================
  Files        6628     6639       +11     
  Lines      296606   296875      +269     
  Branches    51083    51121       +38     
===========================================
+ Hits       141620   231642    +90022     
+ Misses     149831    58960    -90871     
- Partials     5155     6273     +1118     
Files Coverage Δ
...components/feedback/feedbackOnboarding/sidebar.tsx 29.48% <0.00%> (+2.56%) ⬆️
...tatic/app/components/replaysOnboarding/sidebar.tsx 29.29% <0.00%> (+2.02%) ⬆️

... and 3491 files with indirect coverage changes

scttcper added a commit that referenced this pull request Jul 1, 2024
pulling the changes in #73530 into its own pr so CI passes
@scttcper scttcper enabled auto-merge (squash) July 1, 2024 17:06
@scttcper scttcper merged commit eacf691 into master Jul 1, 2024
38 checks passed
@scttcper scttcper deleted the scttcper/typescript-5.5 branch July 1, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants