Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor __init__ #77

Merged
merged 4 commits into from
Apr 26, 2023
Merged

refactor __init__ #77

merged 4 commits into from
Apr 26, 2023

Conversation

12rambau
Copy link
Collaborator

  • First I removed the print statement. it's just fine in a CLI but can be bothersome when using a jupyter notebook and even worse when dashboarding.

  • I used "__" variable to set all the information so that user can access them. the version number was out of reach

import forestatrisk as far

print(far.__author__)
print(far.__email__)
print(far.__version__)
print(far.__doc__)
  • use of a a more pythonic way of testing environ variables

@12rambau
Copy link
Collaborator Author

Hi @ghislainv would you consider this PR or should I close it ?

@ghislainv
Copy link
Owner

Hi @12rambau. Sorry for the delay in considering the PR. I will have a look in the next days.

@12rambau
Copy link
Collaborator Author

no problem I just wanted to help you get rid of gdal for pure python installation but I realized my fork was ahead.

@ghislainv ghislainv merged commit 4d11831 into ghislainv:master Apr 26, 2023
@12rambau
Copy link
Collaborator Author

thanks a lot !

@ghislainv
Copy link
Owner

Thanks to you @12rambau for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants