PUBLIC: Include API name in DoNotCallChecker error message.

PiperOrigin-RevId: 561354031
google · Aug 31, 2023 · 445fac9 · 445fac9
1 parent e0d4682
commit 445fac9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/DoNotCallChecker.java b/core/src/main/java/com/google/errorprone/bugpatterns/DoNotCallChecker.java
@@ -323,7 +323,11 @@ private void checkTree(ExpressionTree tree, MethodSymbol sym, VisitorState state
 
       private void handleDoNotCall(ExpressionTree tree, Symbol symbol, VisitorState state) {
         String doNotCall = getDoNotCallValue(symbol);
-        StringBuilder message = new StringBuilder("This method should not be called");
+        StringBuilder message =
+            new StringBuilder(symbol.owner.toString())
+                .append('.')
+                .append(symbol.toString())
+                .append(" should not be called");
         if (doNotCall.isEmpty()) {
           message.append(", see its documentation for details.");
         } else {

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/DoNotCallCheckerTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/DoNotCallCheckerTest.java
@@ -47,12 +47,13 @@ public void positive() {
             "  @DoNotCall final void g() {}",
             "  void m() {",
             "    // BUG: Diagnostic contains:",
-            "    // This method should not be called: satisfying explanation",
+            "    // Test.f() should not be called: satisfying explanation",
             "    f();",
             "    // BUG: Diagnostic contains:",
-            "    // This method should not be called, see its documentation for details",
+            "    // Test.g() should not be called, see its documentation for details.",
             "    g();",
             "    // BUG: Diagnostic contains:",
+            "    // Test.g() should not be called, see its documentation for details.",
             "    Runnable r = this::g;",
             "  }",
             "}")
@@ -264,7 +265,9 @@ public void noDNConClasspath() {
             "Test.java",
             "class Test {",
             "  void m() {",
-            "    // BUG: Diagnostic contains: This method should not be called",
+            "    // BUG: Diagnostic contains:"
+                + " com.google.errorprone.bugpatterns.DoNotCallCheckerTest.DNCTest.f() should not"
+                + " be called, see its documentation for details.",
             "    com.google.errorprone.bugpatterns.DoNotCallCheckerTest.DNCTest.f();",
             "  }",
             "}")