Upgrade JSpecify 0.2.0 -> 0.3.0 #4059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed `org.jspecify.nullness` package is still supported where possible, but `NullnessUtils#pickNullableAnnotation` now falls back to suggesting `org.jspecify.annotations.Nullable`. See: - https://github.com/jspecify/jspecify/releases/tag/v0.3.0-alpha-1 - https://github.com/jspecify/jspecify/releases/tag/v0.3.0-alpha-2 - https://github.com/jspecify/jspecify/releases/tag/v0.3.0-alpha-3 - https://github.com/jspecify/jspecify/releases/tag/v0.3.0 - jspecify/jspecify@v0.2.0...v0.3.0
Stephan202
commented
Sep 2, 2023
| @@ -353,7 +354,7 @@ private static NullableAnnotationToUse pickNullableAnnotation(VisitorState state | |||
| .orElse( | |||
| state.isAndroidCompatible() | |||
| ? "androidx.annotation.Nullable" | |||
| : "org.jspecify.nullness.Nullable"); | |||
| : "org.jspecify.annotations.Nullable"); | |||
There was a problem hiding this comment.
I filed this PR because an Error Prone suggested fix introduced a org.jspecify.nullness.Nullable usage, while our project uses JSpecify 0.3.0. This caused a build failure. Since version 0.3.0 has been out for more than 8 months it doesn't seem unreasonable to prefer it over the older 0.2.0 release.
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
The removed `org.jspecify.nullness` package is still supported where possible, but `NullnessUtils#pickNullableAnnotation` now falls back to suggesting `org.jspecify.annotations.Nullable`. See: - https://github.com/jspecify/jspecify/releases/tag/v0.3.0-alpha-1 - https://github.com/jspecify/jspecify/releases/tag/v0.3.0-alpha-2 - https://github.com/jspecify/jspecify/releases/tag/v0.3.0-alpha-3 - https://github.com/jspecify/jspecify/releases/tag/v0.3.0 - jspecify/jspecify@v0.2.0...v0.3.0 Fixes #4059 RELNOTES=n/a PiperOrigin-RevId: 562772958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed
org.jspecify.nullnesspackage is still supported wherepossible, but
NullnessUtils#pickNullableAnnotationnow falls back tosuggesting
org.jspecify.annotations.Nullable.See: