Inline RuntimeVersion API #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_662132187
branch
3 times, most recently
from
2fe46ea
to
f97a916
Compare
This used to be a reflective wrapper around Runtime.version() for JDKs that didn't support that API, but now that we're on JDK 11+ it isn't providing a lot of value. Also migrate to using Truth's assume API instead of assumeTrue/assumeFalse. PiperOrigin-RevId: 662700459
copybara-service
bot
force-pushed
the
test_662132187
branch
from
f97a916
to
9aabba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline RuntimeVersion API
This used to be a reflective wrapper around Runtime.version() for JDKs that
didn't support that API, but now that we're on JDK 11+ it isn't providing a lot
of value.
Also migrate to using Truth's assume API instead of assumeTrue/assumeFalse.