Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replaced fast-deep-equal with fast-equals #893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

byt3sage
Copy link

@byt3sage byt3sage commented Jul 5, 2024

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #610 🦕

Hey!
Given the state of fast-deep-equal and the fact I really would like ESM support, I've taken it upon myself to replace fast-deep-equal with fast-equals which is a much more maintained library https://github.com/planttheidea/fast-equals.

Copy link

google-cla bot commented Jul 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@byt3sage
Copy link
Author

byt3sage commented Jul 5, 2024

@wangela would it be at all possible for a review please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change fast-deep-equal to a ESM Library
1 participant