Model Animation
#609
Merged
Model Animation
#609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
commented
Jun 24, 2024
| } | ||
| } | ||
|
|
||
| function validateGopIdentifierAssetName(name: string) { |
There was a problem hiding this comment.
之前实现比较简单粗暴，对所有的 asset name 都做相同的校验
实则只有 sprite & sound 会在编译后对应一个 struct field 定义，因此只应该对 sprite & sound 做 GopIdentifier 的格式限制
|
The PR environment is ready, please check the PR environment [Attention]: This environment will be automatically cleaned up after a certain period of time., please make sure to test it in time. If you have any questions, please contact the builder team. |
ComfyFluffy
reviewed
Jun 25, 2024
ComfyFluffy
reviewed
Jun 25, 2024
ComfyFluffy
reviewed
Jun 25, 2024
ComfyFluffy
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #608, update #543
AnimationSprite&Costumerelated: goplus/spx#289 (we need to upgrade spx version for
tools/ispxafter goplus/spx#289 merged)