-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code-editor for animation #629
Conversation
@@ -196,10 +194,8 @@ function handleConfirm() { | |||
|
|||
watch( | |||
() => props.files, | |||
async (files) => { | |||
cancelMethod(supportedMethods[0].value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里修复之前 #614 引入的 bug:添加 costume 时选择一张图片会得到两个 costume
cancelMethod
也会触发 updateCostumes
,因此会触发几乎同时的两次 updateCostumes
调用(对应相同的参数)
而 updateCostumes
里边
- 清空
selectedCostumes
- 向
selectedCostumes
中添加新的 costumes
两个动作之间间隔了 await Promise.all()
的过程;因此两次 updateCostumes
调用对应地清空了两次 selectedCostumes
,然后又向 selectedCostumes
中添加了两次新的 costumes
最终导致输入一个文件,而 selectedCostumes
中保存了两个 costume
The PR environment is ready, please check the PR environment [Attention]: This environment will be automatically cleaned up after a certain period of time., please make sure to test it in time. If you have any questions, please contact the builder team. |
Update code-editor for animation, update Animation support #543
step
, & update description for existed toolsVariable
toolsFix costume add problem introduced in Costume pre-processing: split-sprite-sheet #614