Left inset & a option to hide highlight line when touched #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IeuanTudurPeace
changed the title
gpbl
requested changes
Jan 6, 2018
There was a problem hiding this comment.
Hi thanks a lot for your pull request. It's OK to add a leftInset, could you provide a screenshot showing with the intended result?
Also, to merge the PR I need you to remove the part related to the highlight line since this feature has been already added with #79
Thanks!
Source/Chart.swift
Outdated
|
|
||
|
|
||
| /** | ||
| Height of the area at the left of the chart, acting a padding to make place for the left x-axis label. |
Source/Chart.swift
Outdated
| context.strokePath() | ||
|
|
||
|
|
||
| if leftInset < 20 { |
Shouldn't of deleted it!
Requested changes
Requested changes
|
Hi @gpbl, sorry for the delay. I have also made changes to fix the issues raised and remove the part related to the highlight. Let me know what you think. I'm happy to make more changes if you think it is needed 😊. Yes here is a screen shot of the intended result: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.