Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support finish-func annotation #1570

Merged
merged 3 commits into from
Jun 2, 2024
Merged

Support finish-func annotation #1570

merged 3 commits into from
Jun 2, 2024

Conversation

A6GibKm
Copy link
Contributor

@A6GibKm A6GibKm commented Jun 1, 2024

To get the correct name of the finish function if any.

@A6GibKm A6GibKm force-pushed the add-finish-func branch 4 times, most recently from c1ec7d8 to c16158e Compare June 1, 2024 11:14
@A6GibKm
Copy link
Contributor Author

A6GibKm commented Jun 1, 2024

Found this in the process https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4099.

sdroege
sdroege approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but we probably have to wait until that ---^--- bug is fixed and we imported that gir?

@bilelmoussaoui
Copy link
Member

Looks good to me but we probably have to wait until that ---^--- bug is fixed and we imported that gir?

Right, at worst we could land this after #1571 and not regen gtk-rs-core until the new gir file lands. So we can test it in gtk4-rs/gstreamer-sr

@bilelmoussaoui
Copy link
Member

The commit mentions it fixes #1561 but it doesn't cover all the other annotations. Even if we don't have an actual use of them now, it would be nice to parse the data so we can find potential breakages in the GIR files

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Jun 2, 2024

The commit mentions it fixes #1561 but it doesn't cover all the other annotations. Even if we don't have an actual use of them now, it would be nice to parse the data so we can find potential breakages in the GIR files

Added a commit I had stashed to parse them, but atm we do nothing with them.

@bilelmoussaoui
Copy link
Member

Needs a rebase

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Jun 2, 2024

Needs a rebase

rebased

@bilelmoussaoui bilelmoussaoui merged commit d26d8f6 into gtk-rs:master Jun 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@A6GibKm @bilelmoussaoui @sdroege