Add spritesheet import logic #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to the SpritesheetImportPanel that automatically sets the default columns/rows if the file width is divisible by the file height. This new logic does not apply when opening the spritesheet from a SpritesheetResource. The user could, for example, have a 64x16 spritesheet that they have already set to be one row and two columns. The new logic would change the number of columns to 4 when opening the spritesheet from a SpritesheetResource. This is likely not what the user would want, so the new logic is not applied in this case.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nightm4re94
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to the SpritesheetImportPanel that automatically sets the default columns/rows if the file width is divisible by the file height.
This new logic does not apply when opening the spritesheet from a SpritesheetResource. The user could, for example, have a 64x16 spritesheet that they have already set to be one row and two columns. The new logic would change the number of columns to 4 when opening the spritesheet from a SpritesheetResource. This is likely not what the user would want, so the new logic is not applied in this case.