Fix tonemap and UV coordinates #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the washed out AR video colors by calling "inverseTonemapSRGB" on the video texture color. This ensures that the tonemap is correctly set when the video is recognized. Additionally this commit removes the extra call to rotate the final image texture. This is due to how Filament, the 3D library beneath ARCore, handles UV (XY) coordinates by default > When set to true (default value), the Y coordinate of > UV attributes will be flipped when read by this > material's vertex shader. Relates to - google/filament#3067 - SceneView/sceneform-android#437
jocmp
commented
Jun 19, 2024
Comment on lines
+82
to
+88
| config.setFocusMode(Config.FocusMode.AUTO) | ||
| config.planeFindingMode = Config.PlaneFindingMode.DISABLED | ||
| session?.apply { | ||
| pause() | ||
| resume() | ||
| pause() | ||
| } |
There was a problem hiding this comment.
Fixes bad autofocus issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the washed out AR video colors by calling "inverseTonemapSRGB" on the video texture color. This ensures that the tonemap is correctly set when the video is recognized.
Additionally this commit removes the extra call to rotate the final image texture. This is due to how Filament, the 3D library beneath ARCore, handles UV (XY) coordinates by default
Relates to