Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick fix for #250 hopefully #251

Merged
merged 1 commit into from
May 3, 2023
Merged

quick fix for #250 hopefully #251

merged 1 commit into from
May 3, 2023

Conversation

roblarsen
Copy link
Member

closes #250

@roblarsen roblarsen linked an issue May 2, 2023 that may be closed by this pull request
npm run lint_js is failing #250
Closed
3 tasks
@roblarsen roblarsen requested a review from coliff May 2, 2023 20:32
@coliff
Copy link
Member

coliff commented May 3, 2023

I still get this warning in the console (it's not an error so I guess it's ok?).

(node:17836) [ESLINT_PERSONAL_CONFIG_SUPPRESS] DeprecationWarning: '~/.eslintrc.*' config files have been deprecated. Please remove it or add 'root:true' to the config files in your projects in order to avoid loading '~/.eslintrc.*' accidentally. (found in "..\..\..\.eslintrc")        
(Use `node --trace-deprecation ...` to show where the warning was created)

@coliff coliff added the dependencies Pull requests that update a dependency file label May 3, 2023
@coliff coliff merged commit 98e65bb into main May 3, 2023
@coliff coliff deleted the 250-npm-run-lint_js-is-failing branch May 3, 2023 05:27
@roblarsen
Copy link
Member Author

@coliff I think I need to fully reconfigure it, but didn't want to go down that path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliff coliff coliff approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm run lint_js is failing
2 participants
@roblarsen @coliff