Fix NULL ptr dereference on EC_POINT *point #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulidale
reviewed
Sep 19, 2024
crypto/ec/ec_oct.c
Outdated
| @@ -74,6 +74,10 @@ size_t EC_POINT_point2oct(const EC_GROUP *group, const EC_POINT *point, | |||
| point_conversion_form_t form, unsigned char *buf, | |||
| size_t len, BN_CTX *ctx) | |||
| { | |||
| if ( point == NULL){ | |||
There was a problem hiding this comment.
Space between the ) and the { please.
citypw
force-pushed
the
ec_point-ptr-null-deref
branch
from
39f3de8
to
ae78e9b
Compare
paulidale
approved these changes
Sep 19, 2024
citypw
force-pushed
the
ec_point-ptr-null-deref
branch
from
ae78e9b
to
f83d496
Compare
Use non-usual params of pkcs11 module will trigger a null ptr deref bug. Fix it for openssl#25493 CLA: trivial
citypw
force-pushed
the
ec_point-ptr-null-deref
branch
from
f83d496
to
60538e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use non-usual params of pkcs11 module will trigger a null ptr deref bug. Fix it for openssl#25493
Checklist