Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run api gateway conformance tests in consul-k8s repository #2163

Closed
wants to merge 7 commits into from

Conversation

sarahalsmiller
Copy link
Member

@sarahalsmiller sarahalsmiller commented May 22, 2023

Changes proposed in this PR:

  • Run gateway-k8s conformance tests against consul-k8 native implementation of the gateway API as a github action by building a docker image of the control plane and loading it onto a kind cluster
  • Tests currently run but fail due to changes that need to be made in the API Gateway code itself

How I've tested this PR:

  • CI kicks off and runs as expected

How I expect reviewers to test this PR:

  • CI runs

Checklist:

  • [ X ] Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@sarahalsmiller sarahalsmiller added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label pr/api-gateway-conformance Label will run PR against API Gateway conformance tests labels May 22, 2023
@sarahalsmiller sarahalsmiller changed the base branch from main to api-gateways May 22, 2023 19:52
Base automatically changed from api-gateways to main May 26, 2023 15:52
@sarahalsmiller sarahalsmiller force-pushed the conformance/run-api-gateway-conformance branch from b399523 to 1734384 Compare May 26, 2023 17:05
@sarahalsmiller sarahalsmiller changed the title [TEST, WIP] Run api gateway conformance tests in consul-k8s repository Run api gateway conformance tests in consul-k8s repository May 30, 2023
@sarahalsmiller sarahalsmiller marked this pull request as ready for review May 30, 2023 22:11
@andrewstucki
Copy link
Member

Tagging @curtbushko to see if this should go here or in our workflows repo. In this case we're running OSS as the target Consul for the conformance tests, so wondering it we don't need the extra safety/configurability of the private runners and this can stay in-repo?

@andrewstucki
Copy link
Member

andrewstucki commented Jun 2, 2023

Also @sarahalsmiller the conformance tests fork are roughly ~1000 commits behind upstreams main. Wondering if we can attempt to target the upstream repo now and target these feature sets:

	SupportReferenceGrant,
	SupportGateway,
	SupportGatewayClassObservedGenerationBump,
	SupportHTTPRoute,
	SupportHTTPRouteQueryParamMatching,
	SupportHTTPRouteMethodMatching,
	SupportHTTPRoutePathRewrite,

As mentioned in Slack, the current repo doesn't ever set the "Ready" status, just "Programmed" as "Ready" has been marked deprecated/for future use (the updated tests look for "Programmed").

@sarahalsmiller
Copy link
Member Author

Closing to move over into consul-k8s-workflows. Will also look at targeting the upstream repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/api-gateway-conformance Label will run PR against API Gateway conformance tests pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants