-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run api gateway conformance tests in consul-k8s repository #2163
Conversation
b399523
to
1734384
Compare
Tagging @curtbushko to see if this should go here or in our workflows repo. In this case we're running OSS as the target Consul for the conformance tests, so wondering it we don't need the extra safety/configurability of the private runners and this can stay in-repo? |
Also @sarahalsmiller the conformance tests fork are roughly ~1000 commits behind upstreams main. Wondering if we can attempt to target the upstream repo now and target these feature sets:
As mentioned in Slack, the current repo doesn't ever set the "Ready" status, just "Programmed" as "Ready" has been marked deprecated/for future use (the updated tests look for "Programmed"). |
Closing to move over into consul-k8s-workflows. Will also look at targeting the upstream repo. |
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: