ci: pass required consul-k8s-workflows checks on CI skip #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalimeni
added
backport/1.1.x
Closed
Unlike local job checks, these will not automatically be considered passing when skipped.
zalimeni
force-pushed
the
zalimeni/skip-ci-pass-required-checks
branch
from
f945287
to
3084407
Compare
zalimeni
removed
the
pr/no-backport
zalimeni
commented
Jun 18, 2024
Comment on lines
+43
to
+53
| - name: Update final status | ||
| uses: docker://ghcr.io/curtbushko/commit-status-action:e1d661c757934ab35c74210b4b70c44099ec747a | ||
| env: | ||
| INPUT_TOKEN: ${{ secrets.ELEVATED_GITHUB_TOKEN }} | ||
| INPUT_REPOSITORY: ${{ github.repository }} | ||
| INPUT_CONTEXT: ${{ matrix.check-name }} | ||
| INPUT_STATE: success | ||
| INPUT_DESCRIPTION: "Skipped due to conditional-skip check" | ||
| INPUT_SHA: ${{ env.SHA }} | ||
| INPUT_DETAILS_URL: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }} | ||
| INPUT_OWNER: "hashicorp" |
There was a problem hiding this comment.
This is basically the same as consul-k8s-workflows, tweaked to clarify that we're skipping and using all the same data we'd normally pass via inputs above
jmurret
approved these changes
Jun 18, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike local job checks, these will not automatically be considered passing when skipped.
Follow-up to #4127 after enabling required checks for acceptance tests.
Changes proposed in this PR
consul-k8s-workflows) when skipping CI due to docs-only changesHow I've tested this PR
#4146 (PR based on this branch, with skipping always on regardless of changed files, since this PR changes files that will not be skipped):
How I expect reviewers to test this PR
👀
Checklist