[NET-10247] Add Partition and Namespace blocks to external registration acl role/policy #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tition, make service address optional like it is for catalog registration
jm96441n
requested review from
a team,
missylbytes and
wangxinyi7
and removed request for
a team
nathancoleman
requested changes
Jul 10, 2024
nathancoleman
approved these changes
Jul 10, 2024
2 tasks
jm96441n
added a commit
that referenced
this pull request
Jul 16, 2024
…on acl role/policy (#4153) * update external registration acl role/policy to include namespace/partition, make service address optional like it is for catalog registration * add changelog * fix typo, update comments for why we don't include ent meta for query options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Dependent on hashicorp/consul#21382
Changes proposed in this PR
addressfield optional in the CRD like it is for catalog registratonHow I've tested this PR
start.shscript in the following gist (ensure you have a local build of this branch and of the changes in the linked consul PR in consul-enterprise and have a valid consul license in an env variable namedCONSUL_LICENSEbenderservice and runapk add curlcurl zoidberg.virtual.consuland see the request go throughzoidberg-write-policyto see thenamespaceblock appliedHow I expect reviewers to test this PR
Checklist