Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case OCSP GET queries that might be corrupted by Go's mux #27475

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stevendpclark
Copy link
Contributor

Description

Workaround an incompatibility between Go's HTTP mux and a standard
OCSP GET request that encodes in standard base64 and places that in the
URL. Go's mux will try to canonicalize path components by changing
repeated '/' into a single '/', which corrupts the base64 encoding of an
OCSP request.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

  Workaround an incompatibility between Go's HTTP mux and a standard
  OCSP GET request that encodes in standard base64 and places that in the
  URL. Go's mux will try to canonicalize path components by changing
  repeated '/' into a single '/', which corrupts the base64 encoding of an
  OCSP request.
@stevendpclark stevendpclark self-assigned this Jun 12, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 12, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant