Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve /reconcile page #400

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Improve /reconcile page #400

merged 5 commits into from
Jun 17, 2024

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Jun 14, 2024

Will resolve #394

@fsteeg fsteeg requested a review from acka47 June 14, 2024 14:54
@fsteeg
Copy link
Member Author

fsteeg commented Jun 17, 2024

As discussed with @acka47 in meeting:

  • Add lobid logo in header
  • Complete page in German

@fsteeg fsteeg assigned fsteeg and unassigned acka47 Jun 17, 2024
@fsteeg
Copy link
Member Author

fsteeg commented Jun 17, 2024

Deployed changes to test: https://test.lobid.org/gnd/reconcile

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Jun 17, 2024
@acka47
Copy link
Contributor

acka47 commented Jun 17, 2024

Apparently, we hav had a misunderstanding. I meant the lobid logo to be put besides the two bigger GND and OpenRefine logos:

image

I think this would make more sense, wouldn't it?

@acka47
Copy link
Contributor

acka47 commented Jun 17, 2024

As discussed offline, we will leave it as is. So, please deploy to production, @fsteeg .

@acka47 acka47 requested review from acka47 and removed request for acka47 June 17, 2024 13:14
Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@acka47 acka47 assigned fsteeg and unassigned acka47 Jun 17, 2024
@fsteeg fsteeg merged commit 17c1c2e into master Jun 17, 2024
1 check passed
@fsteeg fsteeg deleted the 394-reconcilePage branch June 17, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve /reconcile page
2 participants