Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle formData parameters in generated types #746

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

mrlubos
Copy link
Contributor

@mrlubos mrlubos commented Jul 4, 2024

Closes #721

Copy link

stackblitz bot commented Jul 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: 0448823

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 1:11am

@mrlubos mrlubos marked this pull request as ready for review July 4, 2024 01:11
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 73.55%. Comparing base (0e14810) to head (0448823).

Files Patch % Lines
packages/openapi-ts/src/utils/write/types.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
- Coverage   73.59%   73.55%   -0.05%     
==========================================
  Files          78       78              
  Lines        8318     8323       +5     
  Branches      771      771              
==========================================
  Hits         6122     6122              
- Misses       2192     2197       +5     
  Partials        4        4              
Flag Coverage Δ
unittests 73.55% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 24ed655 into main Jul 4, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/client-fetch-body branch July 4, 2024 01:18
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormData/RequestBody not handled correctly with the standalone clients
1 participant