Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support qwenvl glm4-v phi3-v(tested) #4377

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

marko1616
Copy link
Contributor

@marko1616 marko1616 commented Jun 19, 2024

What does this PR do?

Fixes #4375

Before submitting

@hiyouga hiyouga added the pending This problem is yet to be addressed label Jun 19, 2024
@marko1616
Copy link
Contributor Author

终于还差一个image的padding处理就能做好训练支持了。

@marko1616
Copy link
Contributor Author

@hiyouga 改的比较多捏,有空帮忙看看这个实现思路行不行。谢谢。

@marko1616
Copy link
Contributor Author

成功跑了训练。

@marko1616 marko1616 changed the title Feature/support qwenvl glm4-v *WORKING DO NOT MERGE* Feature/support qwenvl glm4-v (tested) Jun 23, 2024
@BUAADreamer BUAADreamer self-requested a review June 28, 2024 17:05
@marko1616 marko1616 changed the title Feature/support qwenvl glm4-v (tested) Feature/support qwenvl glm4-v phi3-v(tested) Jun 30, 2024
@BUAADreamer
Copy link
Collaborator

BUAADreamer commented Jul 1, 2024

暂时先不要引入更多模型,把现有的三个模型完善好,控制diff🤗 @marko1616

@marko1616
Copy link
Contributor Author

暂时先不要引入更多模型,把现有的三个模型完善好,控制diff🤗 @marko1616

oaky,现在确实在测试别的训练模式。

requirements.txt Outdated Show resolved Hide resolved
@marko1616
Copy link
Contributor Author

marko1616 commented Jul 1, 2024

@BUAADreamer Thx for review i'll fix those soon.
Wait for several hours, I will see all of your valuable codes and try my best to give some suggestions!! 🤗

Copy link
Collaborator

@BUAADreamer BUAADreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read all the code, I think this is a great PR. I think we can support more custom MLLMs with your commit!! However, we will discuss and decide when and how to merge it!! 🤗

@marko1616
Copy link
Contributor Author

I have read all the code, I think this is a great PR. I think we can support more custom MLLMs with your commit!! However, we will discuss and decide when and how to merge it!! 🤗

Really THX for your fully review.I will fix those problems in next few days.

Repository owner deleted a comment from marko1616 Jul 2, 2024
README_zh.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending This problem is yet to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] 支持Qwen-VL
3 participants