Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-parameterize the options Keywords objects #6314

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

philippjfr
Copy link
Member

The Keywords object is used to store the allowable keywords for an options object. It was Parameterized but is such a simple object that there is really no need and since it is created very, very frequently this turned out to be a very, very expensive thing to create. In many situations the creation of these objects could account for anywhere between 10-30% of the time to display anything.

@philippjfr philippjfr added the type: enhancement Minor feature or improvement to an existing feature label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (96317ad) to head (c5beb15).
Report is 1 commits behind head on main.

Files Patch % Lines
holoviews/core/options.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6314      +/-   ##
==========================================
- Coverage   88.51%   88.51%   -0.01%     
==========================================
  Files         323      323              
  Lines       68093    68093              
==========================================
- Hits        60272    60271       -1     
- Misses       7821     7822       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member Author

ffmpeg issue unrelated and fixed separately.

@philippjfr philippjfr merged commit 7bc6d11 into main Jul 8, 2024
12 of 14 checks passed
@philippjfr philippjfr deleted the deparameterize_option_keywords branch July 8, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant