Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async.md #4763

Merged
merged 5 commits into from
May 4, 2023
Merged

Update async.md #4763

merged 5 commits into from
May 4, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 3, 2023

Removed aiohttp for pyodide_dependencies.json and removed warning about python 3.8.

See #4561 (comment)

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #4763 (e20762d) into main (12e2810) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4763      +/-   ##
==========================================
- Coverage   83.29%   83.29%   -0.01%     
==========================================
  Files         268      268              
  Lines       37745    37740       -5     
==========================================
- Hits        31441    31435       -6     
- Misses       6304     6305       +1     
Flag Coverage Δ
ui-tests 40.72% <ø> (-0.01%) ⬇️
unitexamples-tests 73.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@philippjfr
Copy link
Member

Wait, actually I'm confused, doesn't that document actually require aiohttp?

@hoxbro
Copy link
Member Author

hoxbro commented May 3, 2023

To be honest, I’m also confused about what I am supposed to do. Adding a dependency which does not work with pyodide.

@philippjfr
Copy link
Member

Suspect we either need to find an alternative to aiohttp or disable pyodide on this page for now.

@MarcSkovMadsen
Copy link
Collaborator

Please align whatever you do with Panelite. There we displayed a red alert and link to the github issue.

@philippjfr
Copy link
Member

I do not think docs pages should link to GitHub issues and I also don't think they should show red alerts. If we can't get it to work we should disable it, not tell users about all the ways it is broken.

@philippjfr philippjfr merged commit a0d03dd into main May 4, 2023
11 of 13 checks passed
@philippjfr philippjfr deleted the async_update branch May 4, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants