-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update async.md #4763
Update async.md #4763
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4763 +/- ##
==========================================
- Coverage 83.29% 83.29% -0.01%
==========================================
Files 268 268
Lines 37745 37740 -5
==========================================
- Hits 31441 31435 -6
- Misses 6304 6305 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Wait, actually I'm confused, doesn't that document actually require aiohttp? |
To be honest, I’m also confused about what I am supposed to do. Adding a dependency which does not work with pyodide. |
Suspect we either need to find an alternative to aiohttp or disable pyodide on this page for now. |
Please align whatever you do with Panelite. There we displayed a red alert and link to the github issue. |
I do not think docs pages should link to GitHub issues and I also don't think they should show red alerts. If we can't get it to work we should disable it, not tell users about all the ways it is broken. |
Removed
aiohttp
for pyodide_dependencies.json and removed warning about python 3.8.See #4561 (comment)