Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to AiDot domain #5485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s1eedz
Copy link

@s1eedz s1eedz commented May 21, 2024

Proposed change

Add icons to Aidot domain

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@frenck
Copy link
Member

frenck commented May 21, 2024

Please explain why you did close the previous PR and created this one.

You seem to have the habit of doing that on all our repositories (closing PRs, re-creating them). Please stop doing that. Open a PR and just keep working on that PR instead.

../Frenck

@s1eedz
Copy link
Author

s1eedz commented May 21, 2024

Please explain why you did close the previous PR and created this one.

You seem to have the habit of doing that on all our repositories (closing PRs, re-creating them). Please stop doing that. Open a PR and just keep working on that PR instead.

../Frenck

I changed the branch name. I didn't know it would close the PR. This was a mistake. I'm very sorry. I won't make this mistake again.

@s1eedz
Copy link
Author

s1eedz commented May 21, 2024

I have a bit of obsessive-compulsive disorder, so I changed the branch names of the three warehouse brands and core and io to be consistent. This is why I want to change the branch names. @frenck

@s1eedz s1eedz changed the title Add icons to Aidot domain Add icons to AiDot domain May 24, 2024
@frenck frenck added the has-parent This PR has a parent PR in a other repo label May 24, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants