Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goldenergy #5618

Closed
wants to merge 4 commits into from
Closed

Add goldenergy #5618

wants to merge 4 commits into from

Conversation

zerolo
Copy link
Contributor

@zerolo zerolo commented Jun 26, 2024

Proposed change

Adding simple icon to ongoing Goldenergy integration

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided branding in this PR, doesn't seem to match the branding the upstream provider is using:

CleanShot 2024-06-26 at 20 56 36@2x

See: https://goldenergy.pt/

Please adjust the branding to match the branding of the integrated service.

Thanks 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 26, 2024 18:57
@zerolo
Copy link
Contributor Author

zerolo commented Jun 26, 2024

Yes, it's intentional in order to not take any risk regarding brand rights of Goldenergy. I'm completely independent from this brand.

@zerolo zerolo marked this pull request as ready for review June 28, 2024 08:04
@home-assistant home-assistant bot requested a review from frenck June 28, 2024 08:04
@frenck
Copy link
Member

frenck commented Jul 5, 2024

Hi there @zerolo 👋

Thanks for being willing to contribute; however, we collect the branding in this repository. We also do not want to misrepresent a brand or publish any customizations that might violate branding guidelines.

Branding images are not required for integrations to function, so for that reason, I'll go ahead and close this PR for now.

../Frenck

@frenck frenck closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants