Mccalluc/consistent names #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR that this is based on goes a long way to make the code more consistent -- This continues that by cleaning up the names. Currently there are a mixture of
conf,config,viewconfandvc. This establishesconfigas the consistent name in the code, andview configin the docs. The couple of places where we're dealing with a dictionary rather than an object are now explicit:config_as_dict.In main there are 90 matches for
confs?(\b|_): Here there are none. Similarly, 97vcs have been cleaned up.I have not gone as far as changing the class names (
ViewConfBuilder) ... Those are internally consistent, and exposed externally, so there's more risk of disruption in changing them.