Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about user input devices #510

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions notebooks/bonus-unit1/bonus-unit1.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,8 @@
"source": [
"1. In step 1, choose your model repository which is the model id (in my case ThomasSimonini/ppo-Huggy).\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"1. In step 1, choose your model repository which is the model id (in my case ThomasSimonini/ppo-Huggy).\n",
"1. In step 1, choose your model repository which is the model id (in my case ThomasSimonini/ppo-Huggy).\n 👉 If you have any racing wheels/flight sim components connected to your computer be sure to disconnect them or you may have trouble selecting your model from the dropdown.",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way 2. will be displayed correctly I think 🤔

"\n",
"👉 If you have any racing wheels/flight sim components connected to your computer be sure to disconnect them or you may have trouble selecting your model from the dropdown.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"👉 If you have any racing wheels/flight sim components connected to your computer be sure to disconnect them or you may have trouble selecting your model from the dropdown.",

"\n",
"2. In step 2, **choose what model you want to replay**:\n",
" - I have multiple ones, since we saved a model every 500000 timesteps.\n",
" - But since I want the more recent, I choose `Huggy.onnx`\n",
Expand Down
4 changes: 3 additions & 1 deletion units/en/unitbonus1/play.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ For this step it’s simple:

1. In step 1, choose your model repository which is the model id (in my case ThomasSimonini/ppo-Huggy).

👉 If you have any racing wheels/flight sim components connected to your computer be sure to disconnect them or you may have trouble selecting your model from the dropdown.

2. In step 2, **choose which model you want to replay**:
- I have multiple ones, since we saved a model every 500000 timesteps.
- But if I want the most recent one I choose Huggy.onnx

👉 It's good to **try with different model checkpoints to see the improvement of the agent.**
👉 It's good to **try with different model checkpoints to see the improvement of the agent.**
Loading