Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/replaced dict keys with list #96

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

erv4gen
Copy link
Contributor

@erv4gen erv4gen commented Nov 1, 2023

Due to the Runtime error in line 70 and 56, replaced .keys() with list() in the for loop

    for bot in st.session_state.active_bots.keys():
RuntimeError: dictionary changed size during iteration 

@cardosofede
Copy link
Contributor

@david-hummingbot @nikspz @rapcmia can we test this behavior? at first sight makes sense

Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Setup dashboard on source ✅
  • Create / Start master_bot_conf successfully
  • Start hummingbot broker
    • Stop master_bot_conf, displays not active on dashboard
    • Start master_bot_conf, running ok
  • Created instances from latest/development
    • Start the bot and select script, ok
    • Stop the bot and observe dashboard behavior, displays non active containers
    • While containers are running relaunch dashboard, all containers ok
  • Run backtests
    • Create, Optimize, Analyze and Deploy ok

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cardosofede cardosofede merged commit 3ef3fdb into hummingbot:main Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants