Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace serde_cbor with ciborium #264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marlonbaeten
Copy link

The crate serde_cbor is unmaintained and has not received any updates in the last 3 years. The author of serde_cbor proposes ciborium as an alternative.
This PR replaces the dependency on serde_cbor with ciborium.

@ryjones
Copy link
Member

ryjones commented Jun 8, 2024

@marlonbaeten @berendsliedrecht take a look and see if this would work

Signed-off-by: Marlon Baeten <[email protected]>
Signed-off-by: Ry Jones <[email protected]>
@andrewwhitehead
Copy link
Member

The Android builds are currently using Rust 1.67 in order to provide broader device support (Rust 1.68 increased the minimum NDK version: https://blog.rust-lang.org/2023/01/09/android-ndk-update-r25.html). I'm not sure if this is still necessary but it seems to conflict with one of the dependencies of ciborium which requires 1.70.

@andrewwhitehead
Copy link
Member

It does look to me like the minimum API version only increased to KitKat which is already under 1% of devices, so I'm not sure how necessary this restriction is. Maybe it's for compatibility with other libraries? @berendsliedrecht

@ryjones
Copy link
Member

ryjones commented Jun 10, 2024

I suggest merging this and bumping the images repo to whatever is new enough.

@TimoGlastra
Copy link
Member

There were some issues we encountered without the custom images in quite recent Android APIs, not sure if that will impact it, but would be good to first test it thoroughly.

I think it was mainly the NDK version.

Berend would know more

@berendsliedrecht
Copy link
Contributor

berendsliedrecht commented Jun 11, 2024

There were some issues we encountered without the custom images in quite recent Android APIs, not sure if that will impact it, but would be good to first test it thoroughly.

I think it was mainly the NDK version.

Berend would know more

IIRC it was mainly due to rust 1.67+ not working for the Android builds. But I am not too sure anymore if that was because of cross or a subdependency.

I see that the CI fails on error: package 'half v2.4.1' cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.67.1. Which means we either have to run cargo update -p [email protected] --precise 2.2.1 and see if that fixes it or see if we can update building android images with 1.70 and fix the occurring errors for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants