Remove return by reference from methods that return self

iFixit · Aug 20, 2024 · 74967c0 · 74967c0
1 parent 8e9b3ba
commit 74967c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/QueryGenerator.php b/QueryGenerator.php
@@ -250,7 +250,7 @@ public function __construct(
     * Append the given clause components and parameters to their existing
     * counterparts for the specified clause.
     */
-   public function &__call($method, $args) {
+   public function __call($method, $args) {
       $method = strtolower($method);
 
       if (!isset(self::$methods[$method])) {
@@ -335,15 +335,15 @@ public function build($skipClauses = false) {
    /**
     * Bypass query validation when building.
     */
-   public function &skipValidation() {
+   public function skipValidation(): self {
       $this->validateQuery = false;
       return $this;
    }
 
    /**
     * Use OR when joining where conditions
     */
-   public function &useOr() {
+   public function useOr(): self {
       $this->useOr = true;
       return $this;
    }

diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -17,8 +17,6 @@
       <code><![CDATA[getPrimaryClauses]]></code>
       <code><![CDATA[getPrimaryMethod]]></code>
       <code><![CDATA[getSetMethods]]></code>
-      <code><![CDATA[skipValidation]]></code>
-      <code><![CDATA[useOr]]></code>
     </MissingReturnType>
     <PossiblyUnusedMethod>
       <code><![CDATA[useOr]]></code>