Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatures: treat dev_block as out-of-date CR 💥 #381

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on May 19, 2023

  1. Signatures: treat dev_block as out-of-date CR

    When you "dev_block" something, have that inject a "synthetic" but
    out-of-date CR signature in the UI. This means that a dev_block somewhat
    reserves a place for you to CR it in the future.
    
    Most dev_blocks come after a review and we generally presume that the
    dev blocker will come back and CR it after the requested changes have
    been made. Therefore, we now show a dev_block as an "inactive" CR.
    
    Also, move the typescript comment to the line it's referring to.
    
    Closes #193
    danielbeardsley committed May 19, 2023
    Configuration menu
    Copy the full SHA
    35c9ea7 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. dev blocks: render them as out-of-date CRs and QAs

    Since a dev block may be made by someone QAing or CRing, and will
    usually end up requiring further CR and QA by the same people, let's
    render a dev block as an out of date CR + QA.
    
    This change counts a block as a CR and QA as far as the leader board is
    concerned
    danielbeardsley committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d9564f8 View commit details
    Browse the repository at this point in the history