Merge branch 'main' into Vulcan--add-html-image-dimensions

.github/workflows/main.yml

@@ -3,7 +3,6 @@ name: E2E tests
 on: [push]
 env:
    npm_config_userconfig: './.npmrc'
-   playwright-upload-result-path: 'playwright-results'
 jobs:
    playwright-run:
       timeout-minutes: 15
@@ -22,12 +21,6 @@ jobs:
          - name: Checkout
            uses: actions/checkout@v3
 
-         - name: Setup CI Environment Variables
-           uses: ./.github/actions/setup-ci-env-vars
-           env:
-              GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-              GITHUB_JOB_NAME: ${{ github.job }} (${{ matrix.project }})
-
          - name: Install Node.js
            uses: actions/setup-node@v3
            with:
@@ -66,51 +59,3 @@ jobs:
               name: playwright-artifacts
               path: frontend/tests/playwright/test-results/artifacts
               retention-days: 7
-
-         - name: Prepare results to upload for project matrix
-           if: success() || failure()
-           id: test-result
-           run: |
-              MATRIX_NAME=$(echo "${{ matrix.project }}" | tr '[:upper:]' '[:lower:]' | tr ' ' '-')
-              RESULT_ORIGINAL_NAME="playwright-result-$BUILD_COMMIT"
-              RESULT_FINAL_NAME="$RESULT_ORIGINAL_NAME-$MATRIX_NAME"
-              mv "frontend/$RESULT_ORIGINAL_NAME" "frontend/$RESULT_FINAL_NAME"
-              RESULT_PATH="frontend/$RESULT_FINAL_NAME"
-              echo "Result path: $RESULT_PATH"
-              echo "result-path=$RESULT_PATH" >> $GITHUB_OUTPUT
-
-         - name: Upload Playwright Test Result Metrics
-           if: success() || failure()
-           uses: actions/upload-artifact@v3
-           with:
-              name: ${{ env.playwright-upload-result-path }}
-              path: ${{ steps.test-result.outputs.result-path }}
-              retention-days: 1
-
-   record-playwright-metrics:
-      name: record-playwright-metrics
-      runs-on: [self-hosted, metrics-runner]
-      needs: [playwright-run]
-      if: success() || failure()
-      timeout-minutes: 5
-      steps:
-         - name: Checkout ifixit
-           uses: actions/checkout@v3
-           with:
-              repository: iFixit/ifixit
-              token: ${{ secrets.ACTION_PAT }}
-
-         - name: Download playwright test results
-           uses: actions/download-artifact@v3
-
-         - name: Install deps
-           run: make deps.unit-tests
-
-         - name: Combine all results
-           run: find "${{ env.playwright-upload-result-path }}" -type f -print0 | xargs -0 cat > playwright-all-test-results
-
-         - name: Preview the results
-           run: cat playwright-all-test-results
-
-         - name: Record test runs
-           run: cat playwright-all-test-results | Tests/Exec/report-test-run

frontend/components/common/CompatibleDevice.tsx

@@ -50,6 +50,7 @@ export function CompatibleDevice({
             wrapper={(children) => (
                <Link
                   href={device.deviceUrl}
+                  flexShrink="0"
                   {...(!truncateModels && {
                      onClick: (event) => event.stopPropagation(),
                   })}
@@ -69,13 +70,15 @@ export function CompatibleDevice({
                borderStyle="solid"
                borderColor="gray.300"
                borderRadius="base"
+               flexShrink="0"
             />
          </ConditionalWrapper>
          <Flex
             minH="12"
             flexDir="column"
             alignItems="flex-start"
             justifyContent="flex-start"
+            wordBreak="break-word"
          >
             <ConditionalWrapper
                condition={!!device.deviceUrl}

frontend/package.json

@@ -101,7 +101,6 @@
       "@types/react-dom": "18.0.8",
       "@types/react-virtualized-auto-sizer": "1.0.1",
       "@types/react-window": "1.8.4",
-      "@types/uuid": "^9.0.2",
       "@typescript-eslint/eslint-plugin": "5.48.1",
       "@typescript-eslint/parser": "5.48.1",
       "babel-jest": "28.1.3",
@@ -126,7 +125,6 @@
       "playwright-msw": "2.1.0",
       "prettier": "2.7.1",
       "typescript": "4.8.4",
-      "uuid": "^9.0.0",
       "webpack": "5.73.0"
    },
    "nextBundleAnalysis": {

frontend/playwright.config.ts

@@ -39,17 +39,17 @@ const config: PlaywrightTestConfig = {
    /* Opt out of parallel tests on CI. */
    workers: process.env.CI ? '100%' : '25%',
    /* Reporter to use. See https://playwright.dev/docs/test-reporters */
-   reporter: process.env.CI
-      ? [['list'], ['./tests/playwright/fixtures/metrics-reporter.ts']]
-      : [
-           [
+   reporter: [
+      process.env.CI
+         ? ['list']
+         : [
               'html',
               {
                  open: 'never', // will not try to automatically open the report in the browser if test fails
                  outputFolder: 'tests/playwright/test-results/reports/',
               },
            ],
-        ],
+   ],
    /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
    use: {
       /* Maximum time each action such as `click()` can take. Defaults to 0 (no limit). */

frontend/tests/jest/tests/__snapshots__/CompatibleDevice.test.tsx.snap

@@ -6,17 +6,17 @@ exports[`CompatibleDevice renders and matches the snapshot 1`] = `
     class="css-1tbib0t"
   >
     <a
-      class="chakra-link css-spn4bz"
+      class="chakra-link css-1ymncv"
       href="/Device/iPhone_6s_Plus"
     >
       <img
         alt="iPhone 6s Plus"
-        class="chakra-image css-wn6w1c"
+        class="chakra-image css-ikbo0y"
         src="https://mmcelvain.cominor.com/igi/cMVbyIbIrTEbi2j5.thumbnail"
       />
     </a>
     <div
-      class="css-7k4xcc"
+      class="css-1q1m9jl"
     >
       <a
         class="css-ce03x1"
@@ -66,17 +66,17 @@ exports[`CompatibleDevice renders and matches the snapshot with truncated varian
     class="css-1tbib0t"
   >
     <a
-      class="chakra-link css-spn4bz"
+      class="chakra-link css-1ymncv"
       href="/Device/iPhone_6s_Plus"
     >
       <img
         alt="iPhone 6s Plus"
-        class="chakra-image css-wn6w1c"
+        class="chakra-image css-ikbo0y"
         src="https://mmcelvain.cominor.com/igi/cMVbyIbIrTEbi2j5.thumbnail"
       />
     </a>
     <div
-      class="css-7k4xcc"
+      class="css-1q1m9jl"
     >
       <a
         class="css-ce03x1"