Merge pull request #2233 from iFixit/ship-app-router-store-home-page

Ship app router store home page
iFixit · Feb 7, 2024 · b03bb50 · b03bb50
2 parents 4cc92d1 + 5e2ac9a
commit b03bb50
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 256 deletions.
diff --git a/frontend/.env.development b/frontend/.env.development
@@ -14,4 +14,4 @@ NEXT_PUBLIC_ALGOLIA_PRODUCT_INDEX_NAME=dev_product_group_en
 NEXT_PUBLIC_DEFAULT_STORE_CODE=test
 
 # Flags
-NEXT_PUBLIC_FLAG__STORE_PAGES_APP_ROUTER_ENABLED=true
+# NEXT_PUBLIC_FLAG__STORE_PAGES_APP_ROUTER_ENABLED=true
diff --git a/...out)/app-router/Store/[[...slug]]/data.ts → ...(defaultLayout)/Store/[[...slug]]/data.ts b/...out)/app-router/Store/[[...slug]]/data.ts → ...(defaultLayout)/Store/[[...slug]]/data.ts
diff --git a/...ut)/app-router/Store/[[...slug]]/page.tsx → ...defaultLayout)/Store/[[...slug]]/page.tsx b/...ut)/app-router/Store/[[...slug]]/page.tsx → ...defaultLayout)/Store/[[...slug]]/page.tsx
@@ -6,7 +6,6 @@ import { QuoteGallerySection } from '@components/sections/QuoteGallerySection';
 import { SocialGallerySection } from '@components/sections/SocialGallerySection';
 import { SplitWithImageContentSection } from '@components/sections/SplitWithImageSection';
 import { IFIXIT_ORIGIN } from '@config/env';
-import { flags } from '@config/flags';
 import { ensureIFixitSuffix } from '@helpers/metadata-helpers';
 import { joinPaths } from '@helpers/path-helpers';
 import { assertNever, invariant } from '@ifixit/helpers';
@@ -26,8 +25,6 @@ export interface StorePageProps {
 }
 
 export default async function StorePage({ params }: StorePageProps) {
-   if (!flags.STORE_PAGES_APP_ROUTER_ENABLED) notFound();
-
    const page = await findPageByPath(pathFor(params.slug));
 
    if (page == null) notFound();

diff --git a/frontend/config/flags.ts b/frontend/config/flags.ts
@@ -1,4 +1,4 @@
 export const flags = {
-   STORE_PAGES_APP_ROUTER_ENABLED:
-      process.env.NEXT_PUBLIC_FLAG__STORE_PAGES_APP_ROUTER_ENABLED === 'true',
+   // STORE_PAGES_APP_ROUTER_ENABLED:
+   //    process.env.NEXT_PUBLIC_FLAG__STORE_PAGES_APP_ROUTER_ENABLED === 'true',
 };
diff --git a/frontend/pages/Store.tsx b/frontend/pages/Store.tsx
diff --git a/frontend/pages/Store/[...slug].tsx b/frontend/pages/Store/[...slug].tsx
diff --git a/frontend/templates/page/hooks/usePageTemplateProps.ts b/frontend/templates/page/hooks/usePageTemplateProps.ts
diff --git a/frontend/templates/page/index.tsx b/frontend/templates/page/index.tsx
diff --git a/frontend/templates/page/meta-tags.tsx b/frontend/templates/page/meta-tags.tsx
diff --git a/frontend/templates/page/server.tsx b/frontend/templates/page/server.tsx