Vulcan: Add html image dimensions for lighthouse #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
- low-hanging prop addition to fix another lighthouse issue
hcutrone
reviewed
Jun 28, 2023
| objectFit="cover" | ||
| src={imageUrl} | ||
| alt="" | ||
| outline="1px solid" | ||
| outlineColor="gray.300" |
There was a problem hiding this comment.
Why did you change border to outline?
Oops I didn't read the CR notes first
hcutrone
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We're getting dinged in Lighthouse for not having html image dimensions applied. Let's add them.
Modified
CR
http://localhost:3000/Vulcan/Dryer_Not_Spinning, etc
I swapped the image
borderin Problem.tsx tooutlineso we can apply dimensions directly and not have to worry about the extra 2px a border would add.Linked to https://github.com/iFixit/ifixit/issues/48516
qa_req 0 (produces no visual changes)