Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulcan: Add featured blockquote styling #1782

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Vulcan: Add featured blockquote styling #1782

merged 4 commits into from
Jun 28, 2023

Conversation

aburke07
Copy link
Contributor

This matches the wiki view styling and applies to all featured blockquotes in Vulcan.

We still need to allow block quotes in the wysiwyg editor, but using plaintext still lets us add a featured block quote to wikis, so this won't break anything.

QA

  1. Open a vulcan wiki and add a featured block quote to the wiki text.
  1. Viewing the Vulcan wiki should render the block quote with this styling:

Part 1 of 2 for https://github.com/iFixit/ifixit/issues/48526

@aburke07
Add featured blockquote styling
5c1739f 
This matches the wiki view styling and applies to all featured
blockquotes
@vercel
Copy link

vercel bot commented Jun 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-commerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 11:09pm
react-commerce-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 11:09pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

ianrohde
ianrohde reviewed Jun 28, 2023
View reviewed changes
Copy link
Contributor

@ianrohde ianrohde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding recommendation instead

@deltuh-vee deltuh-vee self-assigned this Jun 28, 2023
@aburke07 @ianrohde
Add margin to paragraph style in blockquotes
a21785d 
This centers the text in the blockquote. They were vertically offset before.

Co-authored-by: Ian Rohde <[email protected]>
ianrohde
ianrohde previously approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@ianrohde ianrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ⚪

@deltuh-vee deltuh-vee added the QAing Under QA team review label Jun 28, 2023
@deltuh-vee
Copy link
Contributor

QA 🎬
Vulcan pages can now render featured block quotes

@deltuh-vee deltuh-vee removed the QAing Under QA team review label Jun 28, 2023
@aburke07
Copy link
Contributor Author

QA ⏫ Carryover: just prettier changes

ianrohde
ianrohde approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@ianrohde ianrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ⚪

@deltuh-vee
Copy link
Contributor

Carry Over QA 🎬

@deltuh-vee deltuh-vee merged commit 0b018aa into main Jun 28, 2023
@deltuh-vee deltuh-vee deleted the vulcan-add-featured-blockquote branch June 28, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianrohde ianrohde ianrohde approved these changes

Assignees

@deltuh-vee deltuh-vee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aburke07 @deltuh-vee @ianrohde