Vulcan: fix missing linkcard images #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. If a wiki links multiple times to the same guide/product, only show the one linkcard to avoid duplcates.
1. The image from a product variant isn't garunteed to exist. In the rest
of the codebase we always use the first product image (product.image[0])
in case the variant image doesn't exist.
2. Lets do that here too. We can also prefer the thumbnail image because
its smaller and we don't need a large image. If that doesn't exist
either lets fall back to the default product image.
3. The product image isn't garunteed to exist either, but if it doesn't
that means there is no image associated with the product.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
QA 🎬
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some link cards were missing images because the product variant didn't have an image set. The variant image is not guaranteed to exist, and we have always fell back to the first product image. We didn't do that here so we were missing images.
This also removes duplicate link cards from the same solution.
QA
Ex: http://localhost:3000/Vulcan/Nintendo%20Switch%20Blue%20Screen%20of%20Death#display-damage (the
Nintendo Switch Screen OLED Assemblyproduct card)Ex: http://localhost:3000/Vulcan/Nintendo%20Switch%20Blue%20Screen%20of%20Death#Section_CPU_Disconnect
Closes https://github.com/iFixit/ifixit/issues/48545