Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulcan Products: Load via the API #1805

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Vulcan Products: Load via the API #1805

merged 4 commits into from
Jul 7, 2023

Conversation

jarstelfox
Copy link
Contributor

@jarstelfox jarstelfox commented Jul 6, 2023 •
edited
Loading

QA

  • Ensure products on Vulcan pages look the same

Connects: https://github.com/iFixit/ifixit/issues/48101

@vercel
Copy link

vercel bot commented Jul 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-commerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 5:23pm
react-commerce-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 5:23pm

@jarstelfox
Copy link
Contributor Author

jarstelfox commented Jul 6, 2023 •
edited
Loading

deploy_block 🌵 on https://github.com/iFixit/ifixit/pull/48641

@jarstelfox jarstelfox added the external_block QA is not testing this (yet?) label Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/Vulcan/[wikiname] 31.2 KB (🟢 -615 B) 382.53 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

ianrohde
ianrohde previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@ianrohde ianrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ⚪

@jarstelfox
Merge remote-tracking branch 'origin/main' into use-products-added-to…
25fdc3b 
…-troubleshootingapi

 Conflicts:
	frontend/templates/troubleshooting/Resource.tsx
	frontend/templates/troubleshooting/hooks/useTroubleshootingProps.tsx
	frontend/templates/troubleshooting/solution.tsx
ianrohde
ianrohde approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@ianrohde ianrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ⚪

@jarstelfox jarstelfox removed the external_block QA is not testing this (yet?) label Jul 7, 2023
@erinemay
Copy link
Contributor

erinemay commented Jul 7, 2023

un_deploy_block 👍 https://github.com/iFixit/ifixit/pull/48641 is out

@erinemay erinemay added the QAing Under QA team review label Jul 7, 2023
@erinemay
Copy link
Contributor

erinemay commented Jul 7, 2023

QA 👍 product cards appear identical to main

https://react-commerce-git-use-products-added-to-troubles-f41f90-ifixit.vercel.app/Vulcan/Nintendo%20Switch%20Blue%20Screen%20of%20Death

@erinemay erinemay removed the QAing Under QA team review label Jul 7, 2023
@jarstelfox jarstelfox merged commit 88242f8 into main Jul 7, 2023
13 checks passed
@jarstelfox jarstelfox deleted the use-products-added-to-troubleshootingapi branch July 7, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianrohde ianrohde ianrohde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarstelfox @erinemay @ianrohde